Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TagDetector Cleanup and Update RoveComm_CPP Submodule #344

Merged
merged 3 commits into from
Oct 30, 2024
Merged

TagDetector Cleanup and Update RoveComm_CPP Submodule #344

merged 3 commits into from
Oct 30, 2024

Conversation

ClayJay3
Copy link
Collaborator

Description

Add some sanity checks to TagDetector and temporarily comment out cv::Filter2D.

Changes Made

  • Add checks for proper image formats and dimensions.
  • Comment out cv::Filter2D, which was causing TagDetector blowout.
  • Update RoveComm_CPP submodule commit.

@ClayJay3 ClayJay3 added bug Unexpected behaviors or issues that cause the software to malfunction or produce incorrect results. 1-Star Indicates a very easy task or challenge, suitable for beginners with minimal effort required. cleanup Code refactoring or cleanup tasks to remove deprecated features, improve clarity, or ensure code qua labels Oct 30, 2024
@ClayJay3 ClayJay3 self-assigned this Oct 30, 2024
@ClayJay3 ClayJay3 requested a review from a team as a code owner October 30, 2024 01:15
@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Oct 30, 2024 •
edited
Loading

Here's the code health analysis summary for commits 5207c60..20f319e. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Shell LogoShell✅ SuccessView Check ↗
DeepSource Secrets LogoSecrets✅ SuccessView Check ↗
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Docker LogoDocker✅ SuccessView Check ↗
DeepSource C & C++ LogoC & C++✅ SuccessView Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@codecov Codecov
Copy link

codecov bot commented Oct 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 26.20%. Comparing base (5207c60) to head (20f319e).
Report is 4 commits behind head on development.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/vision/aruco/TagDetector.cpp 0.00% 8 Missing ⚠️
src/vision/aruco/ArucoDetection.hpp 0.00% 5 Missing ⚠️
src/vision/aruco/TensorflowTagDetection.hpp 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           development     #344      +/-   ##
===============================================
- Coverage        26.25%   26.20%   -0.05%     
===============================================
  Files               69       69              
  Lines             5310     5320      +10     
  Branches           456      458       +2     
===============================================
  Hits              1394     1394              
- Misses            3916     3926      +10
Files with missing lines Coverage Δ
src/vision/aruco/TensorflowTagDetection.hpp 0.00% <0.00%> (ø)
src/vision/aruco/ArucoDetection.hpp 44.23% <0.00%> (-2.71%) ⬇️
src/vision/aruco/TagDetector.cpp 0.00% <0.00%> (ø)

Byrdman32
Byrdman32 approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@Byrdman32 Byrdman32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fairly certain this looks good

@ClayJay3 ClayJay3 merged commit 6fb3ea8 into development Oct 30, 2024
21 of 23 checks passed
@ClayJay3 ClayJay3 deleted the feature/detector-bug branch October 30, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Byrdman32 Byrdman32 Byrdman32 approved these changes

Assignees

@ClayJay3 ClayJay3

Labels
1-Star Indicates a very easy task or challenge, suitable for beginners with minimal effort required. bug Unexpected behaviors or issues that cause the software to malfunction or produce incorrect results. cleanup Code refactoring or cleanup tasks to remove deprecated features, improve clarity, or ensure code qua
Projects
URC 2025 - Autonomy
Status: Merged
Milestone
URC 2025 - Sprint 2: Testing and Refi...
Development

Successfully merging this pull request may close these issues.
2 participants
@ClayJay3 @Byrdman32